Compte épargne : décrémenter après un créneau libéré #771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petitalb
reviewed
Feb 27, 2023
src/AppBundle/Entity/TimeLog.php
Outdated
| } else { | ||
| return "Créneau (non renseigné)"; | ||
| } | ||
| return "Créneau " . $this->getShiftString($this->shift); |
There was a problem hiding this comment.
Attention à ne pas déplacer la vue dans le contrôleur. C’est pas mal aussi les « macro » doctrine.
There was a problem hiding this comment.
Justement sur ce point précis je me dis qu'on pourrait rajouter une colonne "Créneau" dans le tableau "Compteur de temps" ça simplifierait l'affichage de la description (aka "Motif" dans le tableau)
There was a problem hiding this comment.
je vais partir sur cette option là, et revert les modifs ici
raphodn
force-pushed
the
raphodn/time-log-saving-events
branch
2 times, most recently
from
80e92a9
to
9322e4f
Compare
raphodn
force-pushed
the
raphodn/time-log-saving-event-free
branch
from
c71f62a
to
00d7b95
Compare
raphodn
commented
Feb 28, 2023
| // decrement the savingTimeCount | ||
| $log = $this->container->get('time_log_service')->initSavingTimeLog($member, -1 * $shift->getDuration(), $shift); | ||
| $this->em->persist($log); | ||
| // increment the shiftTimeCount |
quot17
pushed a commit
to quot17/gestion-compte
that referenced
this pull request
Mar 28, 2023
…#771) * onShiftFreed: decrement time from saving * Revert display changes (remove getShiftString) * Add TYPE_SHIFT_FREED_SAVING & initShiftFreedSavingTimeLog. Update messages
OursDesCavernes
pushed a commit
to Les400Coop/gestion-compte
that referenced
this pull request
Jan 20, 2024
…#771) * onShiftFreed: decrement time from saving * Revert display changes (remove getShiftString) * Add TYPE_SHIFT_FREED_SAVING & initShiftFreedSavingTimeLog. Update messages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quoi ?
Lorsque un membre souhaite libérer (annuler) un créneau :
Modifications :
Captures d'écran