Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Time logs : utiliser la méthode DELETE lors de la suppression #856

Merged
merged 3 commits into from
May 17, 2023
Merged

Time logs : utiliser la méthode DELETE lors de la suppression #856

merged 3 commits into from
May 17, 2023

Conversation

raphodn
Copy link
Member

@raphodn raphodn commented May 17, 2023 •
edited
Loading

Quoi ?

Actuellement, la route member_timelog_delete est appelée via la méthode GET

Modifications apportées :

  • utiliser la méthode DELETE
  • créer des formulaires de suppression
  • ajouter une confirmation pour éviter les fausses manip
  • améliorations à la marge (wording, valeurs par défaut des paramètres de templates, commentaires)

Note : cela reste une action réservée aux SUPER_ADMIN

@raphodn raphodn merged commit 2dfd141 into master May 17, 2023
@raphodn raphodn deleted the raphodn/time-log-delete branch May 17, 2023 21:28
@raphodn raphodn self-assigned this May 17, 2023
OursDesCavernes pushed a commit to Les400Coop/gestion-compte that referenced this pull request Jan 20, 2024
@raphodn @OursDesCavernes
Time logs : utiliser la méthode DELETE lors de la suppression (elefan…
7186738 
…-grenoble#856)

* Membership time_log: clarify form name. add scroll to avoid long table

* Ajout de commentaires

* Delete forms for time logs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@raphodn raphodn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@raphodn