v2.0.0 release #55
Merged
v2.0.0 release #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to issues on systems with ownership problems of the module, avoided saving a file in module folder #52
Switched over using puppeteer-core to avoid chromium download on every install. With chrome-launcher, lib will first try to locate any Chromium instance that is installed on users system, and only if not found, it will installed preferred chromium revision that is declared on puppeteer-core pkg. fix #50
Added error handling for chrome-launcher fix #50
Alignment with pptr install script
Added a manual chromium installation step for testing
Added async chrome process cleanup
Added single quotes option for generated HTML tags fix #49
Added an option to generate favicon images and associated meta fix #47
Added puppeteer-core feature details to docs fix #50
Generate iOS splash screen meta with (prefers-color-scheme: dark) media attr [default: false] BREAKING CHANGE: generateImages method from the module API now returns HTMLMeta object with the chunks of HTML content, instead of one big HTML string fix #51
Added a global configuration file jest.setup.js for jest timeout configuration
Better handling of initialization and killing of the browsers for both scenarios of using system browser and package chromium re #50
Suppressed security warning for now by changing package versioning strategy fix #53
sneas
reviewed
Oct 24, 2019
| @@ -98,8 +85,6 @@ test('generates icons and splash screens when both only flags exist', async () = | |||
| }); | |||
|
|
|||
| test('generates icons and splash screens with path prefix', async () => { | |||
| jest.setTimeout(TEST_TIMEOUT_IN_MILLIS); | |||
|
|
|||
sneas
reviewed
Oct 25, 2019
| .reduce( | ||
| (acc, promise: Promise<SavedImage>) => | ||
| acc.then(result => promise.then(Array.prototype.concat.bind(result))), | ||
| Promise.resolve([] as SavedImage[]), |
There was a problem hiding this comment.
More like promise.map or promise.each bro, instead of running all instances in parallel, it executes and kills one by one.
|
🎉 This PR is included in version 2.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #47
fixes #49
fixes #50
fixes #51
fixes #52
fixes #53
Sorry for relatively large review. I hope you can reserve some time for it asap.