Add core typography tokens for Android #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
germain-gg
approved these changes
Feb 14, 2023
Comment on lines
+121
to
+136
| "value": "0.5px", | ||
| "type": "letterSpacing" | ||
| }, | ||
| "sm": { | ||
| "value": "0.4px", | ||
| "type": "letterSpacing" | ||
| }, | ||
| "md": { | ||
| "value": "0.25px", | ||
| "type": "letterSpacing" | ||
| }, | ||
| "lg": { | ||
| "value": "0.25px", | ||
| "type": "letterSpacing" | ||
| } |
There was a problem hiding this comment.
Both iOS and Web use percentages for letter spacing. Is that expected to have pixel values here?
And for my own understanding, what's the rationale behind that?
There was a problem hiding this comment.
I added the rationale to the internal doc on transforming typography tokens, but just realized I haven't pushed it yet. Let me do it now.
There was a problem hiding this comment.
Actually, I pushed it yesterday. https://github.com/vector-im/compound-internal/blob/main/docs/typography.md#android
| @@ -162,6 +162,35 @@ object DarkDesignTokens { | |||
| val cpdColorGray300 = Color(0xffe2e6ea) | |||
| val cpdColorGray200 = Color(0xffeef1f3) | |||
| val cpdColorGray100 = Color(0xfff7f8f9) | |||
| val cpdFontLetterSpacingHeadingXl = 0 | |||
There was a problem hiding this comment.
The output, once again looks wrong. I'll do the same exercise with the Android team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Core typography tokens for Android. Most useful for generating Figma Styles.
Please note that it doesn't include composite tokens for monospace fonts and uppercase text yet.