-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release Announcement component #154
Conversation
Deploying compound-web with Cloudflare Pages
|
44f47a8
to
3833930
Compare
26d03ff
to
3bffb9b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, here are my thoughts:
src/components/ReleaseAnnouncement/ReleaseAnnouncement.stories.tsx
Outdated
Show resolved
Hide resolved
src/components/ReleaseAnnouncement/ReleaseAnnouncement.stories.tsx
Outdated
Show resolved
Hide resolved
} | ||
|
||
.description { | ||
color: var(--cpd-color-gray-500); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to now use color/text/on-solid/primary in the designs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's the case of the header but the description is on Light/color/gray/500
Figma release announcement https://www.figma.com/file/WGM39wEVQSJxnSFf6eeVry/Fixing-Threads-notifs?type=design&node-id=1124-2469&mode=design
This component is under the release announcement folder in storybook.
Following element-hq/compound#298, we are using
floating-ui
instead of radix to avoid accessibility issues on floating/popover/tooltip behavior.