Add breadcrumb component #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying compound-web with
|
| Latest commit: |
4296ddb
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://8eb0c3b6.compound-web.pages.dev |
| Branch Preview URL: | https://florianduros-breadcrumb.compound-web.pages.dev |
florianduros
force-pushed
the
florianduros/breadcrumb
branch
3 times, most recently
from
dbb293c to
de2aefe
Compare
florianduros
requested review from
dbkr and
robintown
and removed request for
a team
florianduros
force-pushed
the
florianduros/breadcrumb
branch
from
de2aefe to
4296ddb
Compare
dbkr
approved these changes
Dec 9, 2024
|
@dbkr Not so bad but a little pain for screen readers :) It's easy to avoid |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Figma design
To avoid the
/separator to be read by a screen reader, I have multiple solutions:<span aria-hidden={true}>/</span>. => I don't like to use an extra span for the separator, to keep the dom simplecontent: "/" / ""instead of the border. => In the accessiblity tree of Chrome, the text is still appearing asstatic text: ""