Remove TODO

element-hq · Oct 5, 2022 · 321fddf · 321fddf
1 parent 3c2e255
commit 321fddf
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 15 deletions.
diff --git a/...src/main/java/im/vector/app/features/home/room/detail/composer/MessageComposerFragment.kt b/...src/main/java/im/vector/app/features/home/room/detail/composer/MessageComposerFragment.kt
@@ -437,8 +437,6 @@ class MessageComposerFragment : VectorBaseFragment<FragmentComposerBinding>(), A
 
     private fun renderVoiceMessageMode(content: String) {
         ContentAttachmentData.fromJsonString(content)?.let { audioAttachmentData ->
-            // TODO: review this behaviour
-//            views.voiceMessageRecorderView.isVisible = true
             messageComposerViewModel.handle(MessageComposerAction.InitializeVoiceRecorder(audioAttachmentData))
         }
     }
@@ -595,17 +593,6 @@ class MessageComposerFragment : VectorBaseFragment<FragmentComposerBinding>(), A
         }
     }
 
-    /**
-     * Returns the root thread event if we are in a thread room, otherwise returns null.
-     */
-    fun getRootThreadEventId(): String? = withState(timelineViewModel) { it.rootThreadEventId }
-
-    /**
-     * Returns true if the current room is a Thread room, false otherwise.
-     */
-    private fun isThreadTimeLine(): Boolean = withState(timelineViewModel) { it.isThreadTimeline() }
-
-
     // AttachmentsHelper.Callback
     override fun onContentAttachmentsReady(attachments: List<ContentAttachmentData>) {
         val grouped = attachments.toGroupedContentAttachmentData()
@@ -787,6 +774,16 @@ class MessageComposerFragment : VectorBaseFragment<FragmentComposerBinding>(), A
         return displayName
     }
 
+    /**
+     * Returns the root thread event if we are in a thread room, otherwise returns null.
+     */
+    fun getRootThreadEventId(): String? = withState(timelineViewModel) { it.rootThreadEventId }
+
+    /**
+     * Returns true if the current room is a Thread room, false otherwise.
+     */
+    private fun isThreadTimeLine(): Boolean = withState(timelineViewModel) { it.isThreadTimeline() }
+
     /** Set whether the keyboard should disable personalized learning. */
     @RequiresApi(Build.VERSION_CODES.O)
     private fun EditText.setUseIncognitoKeyboard(useIncognitoKeyboard: Boolean) {

diff --git a/...main/java/im/vector/app/features/home/room/detail/composer/voice/VoiceRecorderFragment.kt b/...main/java/im/vector/app/features/home/room/detail/composer/voice/VoiceRecorderFragment.kt
@@ -88,8 +88,9 @@ class VoiceRecorderFragment : VectorBaseFragment<FragmentVoiceRecorderBinding>()
     override fun invalidate() = withState(timelineViewModel, messageComposerViewModel) { mainState, messageComposerState ->
         if (mainState.tombstoneEvent != null) return@withState
 
+        val hasVoiceDraft = messageComposerState.voiceRecordingUiState is VoiceMessageRecorderView.RecordingUiState.Draft
         with(views.root) {
-            isVisible = messageComposerState.isVoiceMessageRecorderVisible
+            isVisible = messageComposerState.isVoiceMessageRecorderVisible || hasVoiceDraft
             render(messageComposerState.voiceRecordingUiState)
         }
     }
@@ -188,5 +189,4 @@ class VoiceRecorderFragment : VectorBaseFragment<FragmentVoiceRecorderBinding>()
      * Returns the root thread event if we are in a thread room, otherwise returns null.
      */
     fun getRootThreadEventId(): String? = withState(timelineViewModel) { it.rootThreadEventId }
-
 }