Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Registering with numeric only id will fail and error is displayed wrongly on email field #1410

Closed
BillCarsonFr opened this issue May 26, 2020 · 7 comments
Assignees
Labels
A-Registration T-Defect Something isn't working: bugs, crashes, hangs and other reported problems

Comments

@BillCarsonFr
Copy link
Member

No description provided.

@BillCarsonFr
Copy link
Member Author

from chat

hxuuejjdiifjrj
Hey guys. Thanks for your work on Matrix and RiotX. Installed RiotX today on my mobile and it took me 10 mintues to actually sign up. Tried to sign up as a new user. RiotX insisted on an email despite saying its optional. Joke is on you I guess. Anyways, entered an email address, confirmed the account only to find out then that I cannot use numbers as a username. Nice. Why not telling me this right before I start the whole registration process? Tried to start all over. Didnt work with my email address any longer. Had to use another address then. 10 minutes just for signing up. Hope you can improve that. For now it's too high of a barrier to be used by ordinary mobile phone people

@BillCarsonFr
Copy link
Member Author

mobile
image

web:
image

@bmarty
Copy link
Member

bmarty commented May 26, 2020

Riot-Web does not (sadly) show the error at when you enter the id with only digit, but shows it after you confirm Captcha, email, etc. True it is displayed at a better place though :)

Also it make request to register in a infinite loop when this error occurs, but I should report this issue in Riot-Web project...

image

@bmarty bmarty added T-Defect Something isn't working: bugs, crashes, hangs and other reported problems feature:signup labels May 26, 2020
@bmarty bmarty self-assigned this May 26, 2020
@bmarty
Copy link
Member

bmarty commented May 26, 2020

To fix the issue, I assume we can use https://matrix.org/docs/spec/client_server/latest#get-matrix-client-r0-register-available, hoping it will return the same error.

@bmarty
Copy link
Member

bmarty commented May 26, 2020

Too bad

$ curl -X GET "https://matrix-client.matrix.org/_matrix/client/r0/register/available?username=1234567890"
{
    "available": true
}

@BillCarsonFr BillCarsonFr removed the T-Defect Something isn't working: bugs, crashes, hangs and other reported problems label May 27, 2020
@BillCarsonFr
Copy link
Member Author

see matrix-org/synapse#7576

@BillCarsonFr BillCarsonFr added the T-Defect Something isn't working: bugs, crashes, hangs and other reported problems label May 27, 2020
bmarty added a commit that referenced this issue May 27, 2020
bmarty added a commit that referenced this issue Jun 3, 2020
bmarty added a commit that referenced this issue Jun 3, 2020
Temporary fix to show error when user is creating an account on matrix.org with userId containing only digits (#1410)
@bmarty
Copy link
Member

bmarty commented Aug 19, 2020

Now waiting for matrix-org/synapse#8125 to properly manage this error and removing the temporary patch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Registration T-Defect Something isn't working: bugs, crashes, hangs and other reported problems
Projects
None yet
Development

No branches or pull requests

3 participants