Add new android notification features (Chat bubbles, priority conversations)

[33Fraise33]

Is your feature request related to a problem? Please describe.
When opening the android notification settings it gives a headsup about missing features:

"Element (Riot.im) doesn't support most conversation features. You can't set a conversation as priority, and conversations won't appear as floating bubbles"

This is a native android feature described working here: https://www.androidcentral.com/how-use-chat-bubbles-android-11

Describe the solution you'd like
I'd like this native feature to be implemented so chat bubbles can be used. This is not to be confused with #2388 , #1805 and #979. They are talking about the chat view in app, this is a bubble overlay showing over all apps like Facebook messenger did first.

Describe alternatives you've considered
None existant. This makes quickly looking something up and copying it much easier. Also quickly jumping to a chat while doing something else.

Additional context
/

[AquaWolf]

I also want this feature. I looked a bit in the code perhaps I can program this but still need some more orientation in the code.

[AquaWolf]

Added some lines to enable shortcuts and therefore priority conversation but not sure if I missed something:
dd7c264

[AquaWolf]

I cannot get these bubbles working. As start i added conversation priority in this PR so the notifications can appear in top of other notifications.

[hanthor]

I wonder why the bubbles don't work. I have noticed not many Android apps implement the bubbles feature.

[Peterwmoss]

Any news on this? I would really like to see chat bubbles :)

[ShadowJonathan]

Element-web recently got chat bubbles, so i expect Design to pick up on it and give it to Mobile apps soon

[kevincox]

@ShadowJonathan I think you are confusing two different issues. This is talking about Android Chat Bubbles which is about using the system chat-app overlay feature so that Element is always on-screen. The feature recently added to Element Web is about changing the look of the messages inside of Element.

[ShadowJonathan]

Oh whoops, yeah, i dun goofed for a second 😅

[AquaWolf]

Sorry for this long time not working on this issue actually, I will give this a next try because I really want this feature. I will clean up my PR and try to get these chat bubbles working. I cannot give any timeline for this. Does anybody know who to ping to review my PR after my clean up? I tried to contact @bmarty in matrix.org but I didn't get any response from him :(

[AquaWolf]

Because of native Android 11 chat bubbles I need to implement some kind of view for the chat window in the system overlay any advise for a ui for that?

[AquaWolf]

Thank you @bmarty for reviewing and merging happy to see this feature in the App 👍

[Peterwmoss]

Nice to see updates on this, but does this mean that bubbles are still missing?

[AquaWolf]

Yes Bubbles still missing my PR just included (priority) conversation feature

[Peterwmoss]

Issue should then be reopened, since it doesn't cover the entirety of the issue? Or should there be a separate issue for chat bubbles?

[SimonBrandner]

Issue should then be reopened, since it doesn't cover the entirety of the issue? Or should there be a separate issue for chat bubbles?

That is a different issue - #979

[Peterwmoss]

No, this is not internal to the app. This is an android feature - just as @kevincox mentioned here

[hanthor]

We're talking about Android OS chat bubbles not chat bubbles rendered inside the app

…

________________________________ From: Šimon Brandner ***@***.***> Sent: Friday, October 15, 2021 8:37:40 AM To: vector-im/element-android ***@***.***> Cc: hanthor ***@***.***>; Comment ***@***.***> Subject: Re: [vector-im/element-android] Add new android notification features (Chat bubbles, priority conversations) (#2734) Issue should then be reopened, since it doesn't cover the entirety of the issue? Or should there be a separate issue for chat bubbles? That is a different issue - #979<#979> — You are receiving this because you commented. Reply to this email directly, view it on GitHub<#2734 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABMR4OJVHFHKUXHQ3HZJERTUHAOBJANCNFSM4WXCH5IA>. Triage notifications on the go with GitHub Mobile for iOS<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

[SimonBrandner]

Ah, you're right I got confused and thought the PR added the Android chat bubbles and I thought you were asking about the bubble-themed chat, sorry! 😅 In that case, yes, this should be re-opened/new issue should be opened. I prefer the latter, personally

[AquaWolf]

Yep you're right there must be implemented some special Activity UI for Android chat bubbles. Would be nice to reopen or split this issue just to keep in mind that the chat bubbles are requested.

[abmantis]

@AquaWolf there's already an issue for chat bubbles: #1124 and also #1722

[th0mcat]

For reference, here is the commit to get it working on Signal Android:

signalapp/Signal-Android@e1bf232

There have been changes and fixes in other commits since then I believe.