Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify UTD notice about no messages to unverified devices #1194

Closed
wants to merge 1 commit into from

Conversation

tuxayo
Copy link

@tuxayo tuxayo commented Apr 1, 2020

It's a copy of the message from Riot Web which is much clearer.

Pull Request Checklist

  • Changes has been tested on an Android device or Android emulator with API 16

Is that needed for a string change?

  • UI change has been tested on both light and dark themes

Is that needed for a string change?

  • Pull request is based on the develop branch
  • Pull request updates CHANGES.md

Is that needed for a string change?

  • Pull request includes screenshots or videos if containing UI changes

Is that needed if the string is shorter?

It's a copy of the message from Riot Web which is much clearer.

Signed-off-by: Victor Grousset/tuxayo <victor A@T tuxayo D.T net>
@BillCarsonFr
Copy link
Member

Thanks for the PR

Actually it's more than just the copy, we need to implement MSC2399 matrix-org/matrix-spec-proposals#2399
The sender will now give more information, it'll be then possible to say if the message cannot be decypted because you are black-listed, or your device is not verified, or if it's a real issue with key share

It's tracked here -> #797

and coming very soon

@tuxayo
Copy link
Author

tuxayo commented Apr 9, 2020

Actually it's more than just the copy, we need to implement MSC2399 matrix-org/matrix-spec-proposals#2399
The sender will now give more information, it'll be then possible to say if the message cannot be decypted because you are black-listed, or your device is not verified, or if it's a real issue with key share

How does Riot Web work currently? Does it assume «The sender has disabled encrypting to unverified devices»?
And RiotX Android for now doesn't make that assumption.

@BillCarsonFr
Copy link
Member

Actually it's more than just the copy, we need to implement MSC2399 matrix-org/matrix-doc#2399
The sender will now give more information, it'll be then possible to say if the message cannot be decypted because you are black-listed, or your device is not verified, or if it's a real issue with key share

How does Riot Web work currently? Does it assume «The sender has disabled encrypting to unverified devices»?
And RiotX Android for now doesn't make that assumption.

according to MSC the client is sending a to_device message m.room_key.withheld to the device that will not receive the keys

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants