Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3pid invite #1658

Merged
merged 30 commits into from
Jul 11, 2020
Merged

3pid invite #1658

merged 30 commits into from
Jul 11, 2020

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Jul 10, 2020 •
edited
Loading

Handle first part of #548:

A configured identity server is mandatory to use this feature.

Display contacts of the user with email to be able to create a DM or the invite them to a room.

Some screenshots:

image

image

image

image

image

@bmarty bmarty requested a review from onurays July 10, 2020 09:33
onurays
onurays reviewed Jul 10, 2020
View reviewed changes
vector/src/main/java/im/vector/riotx/core/contacts/ContactsDataSource.kt
import javax.inject.Inject
import kotlin.system.measureTimeMillis

class ContactsDataSource @Inject constructor(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may move this to ContactPicker in multipicker module later.

onurays
onurays approved these changes Jul 10, 2020
View reviewed changes
Copy link
Contributor

@onurays onurays left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! (and there is a conflict on CHANGES.md)

bmarty added 21 commits July 11, 2020 22:07
@bmarty
Render third party invite event (#548)
70e90d8
@bmarty
Invite by email (msisdn not working), command line (#548)
ab1d652
@bmarty
Invite by msisdn. Error 500 from matrix.org though (#548)
3842ec6
@bmarty
Display Contact list (#548)
1c733e6 
WIP (#548)

WIP (#548)

WIP (#548)

WIP (#548)

WIP (#548)
@bmarty
Add checkbox to filter contacts with MatrixId only
6ceac57
@bmarty
Fix a crash (#548)
f51568b
@bmarty
Rename classes
cc4603b
@bmarty
Move classes
327a596
@bmarty
use projection to gain 25% of time
f714566
@bmarty
Add 3Pid to the list. Not compiling, I have to modify CreateRoomParam
6c0bb2a
@bmarty
CreateRoomParams has been replaced by CreateRoomParamsBuilder, to be …
4b3a6a8 
…able to invite 3pids
@bmarty
Handle contacts permission
25e7bbc
@bmarty
Renames package and some other things
4c1d50d
@bmarty
Load contacts much faster
3142442
@bmarty
Display three pid invites in the room members list (#548)
863c091
@bmarty
Revoke ThreePid invitation (#548)
c78bba8
@bmarty
Disable fetching Msisdn, it does not work
3d68b15
@bmarty
Hide right arrow if threepid invite can not be revoked
4ba1a34
@bmarty
Display threePid invite along with the other invite (code is a bit di…
a58bb77 
…rty)
@bmarty
ktlint
e8f28d7
@bmarty
Expose other objects in the builder to create a room
d8a0a1d
@bmarty bmarty force-pushed the feature/3pid_invite branch from 6509e46 to d8a0a1d Compare July 11, 2020 20:11
@bmarty bmarty merged commit eedf545 into develop Jul 11, 2020
@bmarty bmarty deleted the feature/3pid_invite branch July 11, 2020 20:50
@bmarty bmarty mentioned this pull request Aug 5, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onurays onurays onurays approved these changes

Assignees
No one assigned
Labels
Z-riotx-go-live
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bmarty @onurays