Render markdown in room list #2694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I haven't checked so I don't know if that's the case, but if markdown links are also rendered, they should probably not be clickable in the room list, because clicking on the chat can make you accidentally click on a link. |
bmarty
reviewed
Jan 25, 2021
| @@ -82,13 +87,13 @@ class DisplayableEventFormatter @Inject constructor( | |||
| return simpleFormat(senderName, stringProvider.getString(R.string.sent_a_file), appendAuthor) | |||
| } | |||
| MessageType.MSGTYPE_TEXT -> { | |||
| return if (timelineEvent.isReply()) { | |||
| // Skip reply prefix, and show important | |||
There was a problem hiding this comment.
Why have you removed this comment?
| val body = if (timelineEvent.isReply()) timelineEvent.getTextEditableContent() ?: messageContent.body else messageContent.body | ||
| return if (messageContent is MessageTextContent && messageContent.matrixFormattedBody.isNullOrBlank().not()) { | ||
| val localFormattedBody = htmlRenderer.get().parse(body) as Document | ||
| val renderedBody = htmlRenderer.get().render(localFormattedBody) ?: body |
There was a problem hiding this comment.
I haven't check, but this maybe introduce some code duplication here.
bmarty
changed the base branch from
develop
to
feature/bma/markdown_roomlist
|
Will iterate on it on my own branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #452