Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a crash which can happen when user signs out. #3720

Merged
merged 1 commit into from
Jul 22, 2021

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Jul 22, 2021

The crypto DB has been deleted, and the key download request is cancelled, but in the catch block we tried to write to the deleted DB.

Tested OK on my device.

The crypto DB has been deleted, and the key download request is cancelled, but in the catch block we tried to write to the deleted DB
@bmarty bmarty force-pushed the feature/bma/fix_signout_crash branch from eb9748f to 4bbf175 Compare July 22, 2021 10:48
@bmarty bmarty requested review from BillCarsonFr and onurays July 22, 2021 10:48
Copy link
Contributor

@onurays onurays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For a static review LGTM!

@bmarty bmarty merged commit cededa8 into develop Jul 22, 2021
@bmarty bmarty deleted the feature/bma/fix_signout_crash branch July 22, 2021 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants