Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIx / bad format of restricted join rule #3950

Merged
merged 1 commit into from
Sep 2, 2021
Merged

FIx / bad format of restricted join rule #3950

merged 1 commit into from
Sep 2, 2021

Conversation

BillCarsonFr
Copy link
Member

EA was using an old format of restriced join rule

"join_rule": restricted
"allow" : [
    {
      "space" : "!mods:example.org",
      "via": ["m.org","ex.org"]
    }
]

instead of

"join_rule": "restricted",
"allow": [
    {
        "type": "m.room_membership",
        "room_id": "!mods:example.org"
    }
]

@BillCarsonFr BillCarsonFr added A-Spaces Spaces, groups, communities Z-NextRelease For issues and PRs which should be included in the NextRelease. labels Sep 1, 2021
bmarty
bmarty approved these changes Sep 2, 2021
View reviewed changes
Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bmarty bmarty merged commit 2982fdc into develop Sep 2, 2021
@bmarty bmarty deleted the feature/bca/fix_restricted_format branch September 2, 2021 08:49
This was referenced Sep 2, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmarty bmarty bmarty approved these changes

Assignees
No one assigned
Labels
A-Spaces Spaces, groups, communities Z-NextRelease For issues and PRs which should be included in the NextRelease.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BillCarsonFr @bmarty