Feature/pending edits ux #407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ Fix issues with edits local echo management in aggregation
BillCarsonFr
requested review from
bmarty and
ganfra
and removed request for
bmarty
ganfra
approved these changes
Jul 22, 2019
| @@ -31,7 +31,8 @@ data class MessageInformationData( | |||
| val showInformation: Boolean = true, | |||
| /*List of reactions (emoji,count,isSelected)*/ | |||
| var orderedReactionList: List<ReactionInfoData>? = null, | |||
| var hasBeenEdited: Boolean = false | |||
| var hasBeenEdited: Boolean = false, | |||
There was a problem hiding this comment.
we should only get val on this class, could you please change that on the 3 fields?
| @@ -163,7 +164,9 @@ abstract class AbsMessageItem<H : AbsMessageItem.Holder> : BaseEventItem<H>() { | |||
|
|
|||
| protected fun renderSendState(root: View, textView: TextView?) { | |||
| root.isClickable = informationData.sendState.isSent() | |||
| textView?.setTextColor(colorProvider.getMessageTextColor(informationData.sendState)) | |||
| val state = SendState.UNSENT.takeIf { informationData.hasPendingEdits } | |||
There was a problem hiding this comment.
I think a basic If else would be more readable
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Show pending edits by fading the event body
Fixes #193