A few changes on the slash command #4268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
bmarty
commented
Oct 19, 2021
bmarty
commented
- Fixes Slash commands are not robust anymore to exceptions #4261 in 364654b
- Fixes /part doesn't part without parameters #2909 : Implement /part command> I've left /leave command there, even if it is not present in EleWeb. Leaving an unknown room will have no effect, I think we can improve that later, this is a very technical command.
- Add a loader when a slash command is running, and clear draft only in case of success (better UX)
- Also update some wording, translation can be updated later (no need to create a new string)
ganfra
approved these changes
Oct 19, 2021
| } | ||
| } else { | ||
| ParsedCommand.ErrorSyntax(Command.PART) | ||
| when (messageParts.size) { |
There was a problem hiding this comment.
It's not equivalent to the code you replace, is it ok?
There was a problem hiding this comment.
reason is removed here (iso EleWeb), if this is your concern.
ouchadam
reviewed
Oct 19, 2021
| popDraft() | ||
| } | ||
| is ParsedCommand.ChangeTopic -> { | ||
| handleChangeTopicSlashCommand(slashCommandResult) | ||
| popDraft() |
There was a problem hiding this comment.
is popDraft not needed for these commands or was it the cause of the crash?
There was a problem hiding this comment.
popDraft is now handled by handleChangeTopicSlashCommand (in launchSlashCommandFlowSuspendable)
There was a problem hiding this comment.
the crash fix is just 364654b
ouchadam
approved these changes
Oct 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.