Code

Single PushTriggerListener dispatch#4401

Code

Merged

ouchadam merged 11 commits intofeature/adm/feature-notification-imageselement-hq/element-android:feature/adm/feature-notification-imagesfrom feature/adm/single-transaction-pushelement-hq/element-android:feature/adm/single-transaction-pushCopy head branch name to clipboardNov 5, 2021

+551-304

Commits

Commits on Nov 3, 2021

• replacing separated push listener callbacks with a single onEvents callback

  Show description for 5096318
  ouchadam

  committed
  5096318

• extracting the notification event logic to its own class and provide a single update point of entry for mutating the events

  Show description for 57f7d83
  ouchadam

  committed
  57f7d83

• flattening some of the onNotifiableEventReceived branches to simplify the chain

  ouchadam

  committed
  6e0bd03

• moving the notifable queue adding to the queue itself and making onNotifiableEventReceived not synchronised for use within the synchronized batching

  Show description for 4014638
  ouchadam

  committed
  4014638

• extracting notifiable event creation to its own function

  ouchadam

  committed
  b76f881

• cleaning up method ordering and visibility

  ouchadam

  committed
  7b38a06

• extracting notifiable event fixtures to their own file

  ouchadam

  committed
  cd9175b

• adding test cases around the mutating of the notification event queue

  ouchadam

  committed
  576d945

• adding catch around the push event dispatching to match previous behaviour

  ouchadam

  committed
  5f13ba0

• updating copyright header

  ouchadam

  committed
  805f09f

• add changelog entry for breaking API change

  ouchadam

  committed
  88fbb8f