Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/4292 fix capitalisation on initial sync screen #4410

Conversation

AdamTomaja
Copy link
Contributor

Simple change fixing some texts on initial sync screen

Pull Request Checklist

Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR. Can you fix some remaining capitalisations please?

vector/src/main/res/values/strings.xml Outdated Show resolved Hide resolved
vector/src/main/res/values/strings.xml Outdated Show resolved Hide resolved
vector/src/main/res/values/strings.xml Outdated Show resolved Hide resolved
@ouchadam
Copy link
Contributor

ouchadam commented Nov 4, 2021

@bmarty how do we want to handle the other locales with similar issues, should we raise separate issues for them?

@AdamTomaja
Copy link
Contributor Author

Thanks for your PR. Can you fix some remaining capitalisations please?

done :)

Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update!
Will be in release 1.3.7

@bmarty bmarty enabled auto-merge (squash) November 4, 2021 11:29
@bmarty bmarty merged commit e167db2 into element-hq:develop Nov 4, 2021
@AdamTomaja AdamTomaja deleted the feature/4292-fix-capitalisation-on-initial-sync-screen branch November 5, 2021 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants