Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Developer mode sanity check & failure screenshots #4439

Merged
merged 16 commits into from
Nov 10, 2021
Merged

Developer mode sanity check & failure screenshots #4439

merged 16 commits into from
Nov 10, 2021

Conversation

ouchadam
Copy link
Contributor

@ouchadam ouchadam commented Nov 9, 2021 •
edited
Loading 

- Advanced Settings 
  - Account Data
  - Key Requests

- Message Actions
  - View Source

@github-actions
Copy link

github-actions bot commented Nov 9, 2021 •
edited
Loading

Unit Test Results

  62 files  ±0    62 suites  ±0   49s ⏱️ -7s
118 tests ±0  118 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
350 runs  ±0  350 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 4264829. ± Comparison against base commit 474e2aa.

♻️ This comment has been updated with latest results.

bmarty
bmarty approved these changes Nov 10, 2021
View reviewed changes
Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's all good to me, thanks for this amazing work! You just have to run .gradlew ktlintFormat to make this PR mergeable!

@ouchadam
adding helper to fetch text from resources
2a66efb
@ouchadam
adding dedicated message menu robot and adding sanity check for devel…
e5edfe9 
…oper mode flows
@ouchadam
adding bottomsheet idling resource to wait for expand and hide events
39b4116
@ouchadam
waiting for the message actions bottom sheet when interacting with th…
fc86568 
…e message options
@ouchadam
taking screenshots on sanity test failure
2583a6d
@ouchadam
adding screenshot pulling and storing as part of the sanity workflow
0a1f4dd
@ouchadam
adding github action emulator optimisations
918042c
@ouchadam
waiting for the edited text to appear instead of sleeping
411be43
@ouchadam
removing unused imports
c8ae3f9
@ouchadam
waiting for the sent message to be rendered in the timeline
10a8a45
@ouchadam
adding missing indentation
70dd3e5
@ouchadam
using single line for the emulator script, doesn't seem to support mu…
0ab5734 
…ltiline
@ouchadam
updating emulator to use api 29 due to storage differences
992c3d8
@ouchadam
using adb root for pulling off emulator files as per ReactiveCircus/a…
968d8e4 
…ndroid-emulator-runner#102 (comment)

- also uses emulated directory instead of sdcard
@ouchadam
adding logcat output to the sanity artifacts
9152c39
@ouchadam
formatting
4264829
@ouchadam ouchadam force-pushed the feature/adm/developer-mode-sanity-check branch from 25f1c1a to 4264829 Compare November 10, 2021 17:09
@ouchadam
Copy link
Contributor Author

ah, I was getting false positives locally, updated 4264829

@bmarty bmarty merged commit 8b655ed into develop Nov 10, 2021
@bmarty bmarty deleted the feature/adm/developer-mode-sanity-check branch November 10, 2021 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmarty bmarty bmarty approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add action View source to the sanity test
2 participants
@ouchadam @bmarty