Fix Sending Stickers from Dimension doesn't work

[acheng-floyd]

Fixes: Sending Stickers from Dimension doesn't work #1497

A saclar token is needed by self deployed dimension when using sticker picker.
Fix roomid check is no needed when using sticker picker

Noted: there still problem to enable sticker picker for the first time, if we want to use sticker picker, we should enable it on element-web then we can use sticker picker in android with self deployed dimension

Here's what your changelog entry will look like:

🐛 Bug Fixes
Fixes: Sending Stickers from Dimension doesn't work #1497. Contributed by @achengfloyd

Before fix:

After fix:

[ouchadam]

if it's no longer needed lets delete the code rather than commenting out ♻️

[ouchadam]

I'm wondering if this could be simplified to

val allWidgets = when {
    eventData.isMissingRoomId() -> session.widgetService().getUserWidgets()
    roomId == eventData.roomId  -> session.widgetService().getRoomWidgets(roomId) + session.widgetService().getUserWidgets()
    else                        -> {
        widgetPostAPIMediator.sendError(stringProvider.getString(R.string.widget_integration_room_not_visible), eventData)
        return
    }
}

[acheng-floyd]

That looks nice, but i try your code in my ide, it looks like this

I'm sorry i'm really not familiar with kotlin, i just try to use the easy way i could understand~~

[ouchadam]

ah my bad! this was a mix of pseudo code, these could be implemented as kotlin extension functions on the JsonDict, we could also extract another for matching against the room id

private fun getWidgets(widgetPostAPIMediator: WidgetPostAPIMediator, eventData: JsonDict) {
  val allWidgets = when {
      eventData.isMissingRoomId()        -> session.widgetService().getUserWidgets()
      eventData.hasMatchingRoom(roomId)  -> session.widgetService().getRoomWidgets(roomId) + session.widgetService().getUserWidgets()
      else                               -> {
          widgetPostAPIMediator.sendError(stringProvider.getString(R.string.widget_integration_room_not_visible), eventData)
          return
      }
  }
  ... 
}

private fun JsonDict.isMissingRoomId() = (this["room_id"] as? String).isNullOrEmpty()
private fun JsonDict.hasMatchingRoom(roomId: String) = (this["room_id"] as? String) == roomId

[bmarty]

OK, I have made a small mistake when fixing the conflict, the code will not compile. Can you add a sign-off to the PR, so that I can merge it to one of my branch to be able to fix the issue? Thanks @acheng-floyd

[bmarty]

Stale PR, feel free to update and re-open.