Feature/attachments #619
Merged
Feature/attachments #619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmarty
requested changes
Oct 11, 2019
| @@ -48,3 +48,10 @@ fun EditText.showPassword(visible: Boolean, updateCursor: Boolean = true) { | |||
| } | |||
| if (updateCursor) setSelection(text?.length ?: 0) | |||
| } | |||
|
|
|||
| fun View.getMeasurements(): Pair<Int, Int> { | |||
There was a problem hiding this comment.
Create a data class to avoid using generic pair? (give sense to first and second)
There was a problem hiding this comment.
This is just a utility method, I don't think it's worth it
vector/src/main/java/im/vector/riotx/features/share/IncomingShareActivity.kt
Show resolved
Hide resolved
vector/src/main/java/im/vector/riotx/features/share/IncomingShareActivity.kt
Outdated
Show resolved
Hide resolved
vector/src/main/java/im/vector/riotx/features/attachments/AttachmentsHelper.kt
Outdated
Show resolved
Hide resolved
…iewState and should be provided globally (IE, from application state)
bmarty
reviewed
Oct 18, 2019
vector/src/main/java/im/vector/riotx/features/share/IncomingShareActivity.kt
Outdated
Show resolved
Hide resolved
bmarty
requested changes
Oct 18, 2019
bmarty
reviewed
Oct 18, 2019
| @@ -192,9 +196,12 @@ class RoomDetailFragment : | |||
|
|
|||
| private lateinit var actionViewModel: ActionsHandler | |||
| private lateinit var layoutManager: LinearLayoutManager | |||
| private lateinit var attachmentsHelper: AttachmentsHelper | |||
| private lateinit var keyboardStateUtils: KeyboardStateUtils | |||
There was a problem hiding this comment.
Let the activity manages KeyboardStateUtils?
bmarty
reviewed
Oct 18, 2019
vector/src/main/java/im/vector/riotx/features/attachments/ContactAttachment.kt
Outdated
Show resolved
Hide resolved
bmarty
reviewed
Oct 18, 2019
vector/src/main/java/im/vector/riotx/features/home/room/filtered/FilteredRoomsActivity.kt
Show resolved
Hide resolved
bmarty
reviewed
Oct 18, 2019
bmarty
reviewed
Oct 18, 2019
|
I've added some remarks. |
bmarty
reviewed
Oct 18, 2019
vector/src/main/java/im/vector/riotx/features/home/room/detail/RoomDetailFragment.kt
Show resolved
Hide resolved
This was referenced Oct 18, 2019
Closed
|
Also if you refuse the contact permission once, the next time you try to share a contact, a dialog is displayed with a wrong explanation of why the app needs the contact permission. |
bmarty
approved these changes
Oct 22, 2019
vector/src/main/java/im/vector/riotx/features/home/room/detail/composer/ComposerEditText.kt
Show resolved
Hide resolved
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the use of inner picker by using system picking mechanisms.
It's just the beginning of the work for handling media, we should handle in the future:
- Preview of media
- Allow to compress image
- Handle video encoding
Preview:
