Feature/handle matrix to #706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmarty
reviewed
Dec 5, 2019
| /** | ||
| * Resolve a room alias to a room ID. | ||
| */ | ||
| fun getRoomIdByAlias(roomAlias: String, searchOnServer: Boolean, callback: MatrixCallback<Optional<String>>): Cancelable |
| internal fun RoomSummaryEntity.Companion.findByAlias(realm: Realm, roomAlias: String): RoomSummaryEntity? { | ||
| val roomSummary = realm.where<RoomSummaryEntity>() | ||
| .equalTo(RoomSummaryEntityFields.CANONICAL_ALIAS, roomAlias) | ||
| .findFirst() |
There was a problem hiding this comment.
I think this is not necessary because the canonical alias is also in the alias list, no?
|
|
||
| internal class MatrixCallbackSingle<T>(private val singleEmitter: SingleEmitter<T>) : MatrixCallback<T> { | ||
| @JsonClass(generateAdapter = true) | ||
| data class RoomAliasDescription( |
| android:parentActivityName=".features.home.HomeActivity"> | ||
| <meta-data | ||
| android:name="android.support.PARENT_ACTIVITY" | ||
| android:value=".features.home.HomeActivity" /> |
There was a problem hiding this comment.
Is it ok If we open the RoomDetailActivity from a notification? Today we already go back to the Home. We should check that.
| @@ -1768,5 +1768,6 @@ Not all features in Riot are implemented in RiotX yet. Main missing (and coming | |||
| <string name="permissions_rationale_msg_keys_backup_export">Riot needs permission to save your E2E keys on disk.\n\nPlease allow access on the next pop-up to be able to export your keys manually.</string> | |||
|
|
|||
| <string name="no_network_indicator">There is no network connection right now</string> | |||
| <string name="permalink_malformed">Your matrix.to link was malformed</string> | |||
|
Also the case correct room but unknown event does not work, we get an infinite loading Ex: https://matrix.to/#/!QtykxKocfZaZOUrTwp:matrix.org/$INVALIDID:matrix.org?via=matrix.org Riot-Web display this dialog: |
bmarty
force-pushed
the
feature/handle_matrix_to
branch
from
ba63c60 to
e2b4899
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for opening matrix.to link from outside the app (#57) and map room alias to roomId for joined room (#201 )