-
Notifications
You must be signed in to change notification settings - Fork 760
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Device Management] Save matrix_client_information events on login/registration (PSG-769, PSG-771) #7276
Conversation
Need to fix the |
383cef9
to
fbb6aa5
Compare
I changed the implementation to ease the testing (see 5647e7b), normally it should be okay now. |
5647e7b
to
71f15d4
Compare
71f15d4
to
4aca1dc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Kudos, SonarCloud Quality Gate passed! |
Type of change
Content
Adding a new step after the
Session
has been configured and started: update if needed of Matrix client info inAccountData
which will be used inSession
details screen to renderApplication
section.A new use case has been introduced
ConfigureAndStartSessionUseCase
which replaces the extension methodSession.configureAndStart()
.Motivation and context
Closes #7257
Screenshots / GIFs
N/A
Tests
AccountData
is correctly sent when client info has changed (app name or version)Tested devices
Checklist