Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Voice Broadcast - Do not display the recording tile on the other sessions #7449

Merged
merged 2 commits into from
Oct 26, 2022
Merged

Voice Broadcast - Do not display the recording tile on the other sessions #7449

merged 2 commits into from
Oct 26, 2022
+4 −1

Conversation

Florian14
Copy link
Contributor

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Add a check on the recorder device id before showing the recording or listening tile in the timeline

Motivation and context

Fix #7431

Screenshots / GIFs

Tests

  • Record a voice broadcast on a sessionA in a room
  • Open the room with a sessionB while the voice broadcast is live
  • Verify that the sessionB is in a listening state (can start/pause listening to the VB but cannot pause or stop the recording)

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

@Florian14 Florian14 requested review from a team and fedrunov and removed request for a team October 25, 2022 14:58
@Florian14 Florian14 added the PR-Small PR with less than 20 updated lines label Oct 25, 2022
@Florian14 Florian14 force-pushed the feature/fre/voice_broadcast_device_id branch from 1b7928e to a4eff0c Compare October 25, 2022 15:56
mnaturel
mnaturel approved these changes Oct 26, 2022
View reviewed changes
Copy link
Contributor

@mnaturel mnaturel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

Base automatically changed from feature/fre/voice_broadcast_timeline_improvements to resilience-rc October 26, 2022 09:53
@Florian14 Florian14 merged commit 65a5ae9 into resilience-rc Oct 26, 2022
@Florian14 Florian14 deleted the feature/fre/voice_broadcast_device_id branch October 26, 2022 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnaturel mnaturel mnaturel approved these changes

@fedrunov fedrunov Awaiting requested review from fedrunov fedrunov was automatically assigned from element-hq/element-android-reviewers

Assignees
No one assigned
Labels
PR-Small PR with less than 20 updated lines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Florian14 @mnaturel