Remove usage of Buildkite. #7583

bmarty · 2022-11-14T14:27:27Z

Type of change

Feature
Bugfix
Technical
Other :

Content

Remove usage of Buildkite.
Build number is just removed.
Related script will need to be updated separately.

Motivation and context

Closes #7493

Release script will have to be updated for the next release, but it's not part of the project file.

TODO:

Update topic of https://matrix.to/#/#element-android:matrix.org

Screenshots / GIFs

Tests

NA

Tested devices

Physical
Emulator
OS version(s):

Checklist

Changes has been tested on an Android device or Android emulator with API 21
UI change has been tested on both light and dark themes
Accessibility has been taken into account. See https://github.com/vector-im/element-android/blob/develop/CONTRIBUTING.md#accessibility
Pull request is based on the develop branch
Pull request includes a new file under ./changelog.d. See https://github.com/vector-im/element-android/blob/develop/CONTRIBUTING.md#changelog
Pull request includes screenshots or videos if containing UI changes
Pull request includes a sign off
You've made a self review of your PR
If you have modified the screen flow, or added new screens to the application, you have updated the test UiAllScreensSanityTest.allScreensTest()

ElementBot · 2022-11-14T15:03:55Z

	Warnings
⚠️	vector/src/main/AndroidManifest.xml#L201 - Consider splitting data tag into multiple tags with individual attributes to avoid confusion
⚠️	vector/src/main/AndroidManifest.xml#L201 - Consider splitting data tag into multiple tags with individual attributes to avoid confusion
⚠️	vector/src/main/AndroidManifest.xml#L204 - Consider splitting data tag into multiple tags with individual attributes to avoid confusion
⚠️	vector/src/main/AndroidManifest.xml#L204 - Consider splitting data tag into multiple tags with individual attributes to avoid confusion
⚠️	vector/src/main/AndroidManifest.xml#L258 - Expecting `android:screenOrientation="unspecified"` or `"fullSensor"` for this activity so the user can use the application in any orientation and provide a great experience on Chrome OS devices
⚠️	vector/src/main/AndroidManifest.xml#L258 - Expecting `android:screenOrientation="unspecified"` or `"fullSensor"` for this activity so the user can use the application in any orientation and provide a great experience on Chrome OS devices
⚠️	vector/src/main/AndroidManifest.xml#L267 - Attribute `supportsPictureInPicture` is only used in API level 24 and higher (current min is 21)
⚠️	vector/src/main/AndroidManifest.xml#L267 - Attribute `supportsPictureInPicture` is only used in API level 24 and higher (current min is 21)
⚠️	vector/src/main/AndroidManifest.xml#L274 - Attribute `supportsPictureInPicture` is only used in API level 24 and higher (current min is 21)
⚠️	vector/src/main/AndroidManifest.xml#L274 - Attribute `supportsPictureInPicture` is only used in API level 24 and higher (current min is 21)
⚠️	vector/src/main/AndroidManifest.xml#L280 - Attribute `supportsPictureInPicture` is only used in API level 24 and higher (current min is 21)
⚠️	vector/src/main/AndroidManifest.xml#L280 - Attribute `supportsPictureInPicture` is only used in API level 24 and higher (current min is 21)
⚠️	vector/src/main/AndroidManifest.xml#L400 - Exported receiver does not require permission
⚠️	vector/src/main/AndroidManifest.xml#L400 - Exported receiver does not require permission

Generated by 🚫 dangerJS against 492e842

mnaturel · 2022-11-15T09:30:46Z

.github/ISSUE_TEMPLATE/release.yml

-        - [ ] Wait for [Buildkite](https://buildkite.com/matrix-dot-org/element-android/builds?branch=main) to build the `main` branch.
-        - [ ] Run the script `~/scripts/releaseElement.sh`. It will download the APKs from Buildkite check them and sign them.
+        - [ ] Wait for the [GitHub action](https://github.com/vector-im/element-android/actions/workflows/build.yml?query=branch%3Amain) to build the `main` branch.
+        - [ ] (TODO This script has to be updated) *Run the script `~/scripts/releaseElement.sh`. It will download the APKs from Buildkite check them and sign them.*


Out of curiosity, where is this releaseElement.sh script?

This script is not shared publicly, but uses scripts that are public and in the repository, like download_buildkite_artifacts.py and sign_apk_unsafe.sh.

@mnaturel f752146

Can you check the script on your side?

The script seems to work well on my side. I think we need to add a small doc about this script somewhere to explain how to use it.

mnaturel · 2022-11-15T09:37:27Z

tools/install/installFromBuildkite.sh

@@ -3,6 +3,9 @@
 # Exit on any error
 set -e

+echo "Sorry, this script needs to be updated to download APKs from GitHub action. Buildkite is not building APKs anymore."


Will the script be updated in another dedicated PR?

I guess I will write another script to install from GitHub, but yes, in another PR. I will write it during the next release.

(Actually I am working on it right now)

mnaturel

Right now I have this for local build in the splashscreen:

I don't know if this is already the case but, in the case of a CI build, do you know if it would be possible to add the commit hash after the branch name to have more precision about where we are in the branch?

mnaturel · 2022-11-17T09:10:02Z

@bmarty When testing a build from this PR using the script, I get this info on the splashscreen:

We have HEAD for the branch name but I don't know why. And I cannot find the hash commit bd62fbed in the repo. Do you have an idea of what is happening?

Build number is just removed. Related script will need to be updated separately.

…ce screen)

bmarty · 2022-11-24T14:40:03Z

@mnaturel I have updated the PR to add a docs to use ./tools/install/installFromGitHub.sh.

For the version I have (nearly) the same issue:

I will have a look, but I think it should not block this PR.

mnaturel

LGTM.

sonarqubecloud · 2022-11-24T17:49:12Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

30.0% Coverage
0.0% Duplication

bmarty requested review from a team and mnaturel and removed request for a team November 14, 2022 14:27

mnaturel reviewed Nov 15, 2022

View reviewed changes

bmarty added 6 commits November 24, 2022 14:49

Remove usage of Buildkite.

9ca7415

Build number is just removed. Related script will need to be updated separately.

changelog

cccfad0

Add git commit sha to the version details (splash screen and preferen…

8795ddb

…ce screen)

Install app from GitHub action

83a10c3

Buildkite scripts can still be used.

451df75

Add doc for script installFromGitHub.sh

211c0c2

bmarty force-pushed the feature/bma/remove_buidkite branch from 12a797f to 211c0c2 Compare November 24, 2022 14:36

bmarty added 2 commits November 24, 2022 16:43

Add section about knit tool

deb4730

Run knit.

fa3b440

mnaturel approved these changes Nov 24, 2022

View reviewed changes

Fix the fixture.

492e842

bmarty merged commit 27419f0 into develop Nov 24, 2022

bmarty deleted the feature/bma/remove_buidkite branch November 24, 2022 17:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove usage of Buildkite. #7583

Remove usage of Buildkite. #7583

bmarty commented Nov 14, 2022 •

edited

Loading

ElementBot commented Nov 14, 2022 •

edited

Loading

mnaturel Nov 15, 2022

bmarty Nov 16, 2022

bmarty Nov 16, 2022

mnaturel Nov 17, 2022

mnaturel Nov 15, 2022

bmarty Nov 16, 2022

bmarty Nov 16, 2022

mnaturel left a comment

mnaturel commented Nov 17, 2022

bmarty commented Nov 24, 2022

mnaturel left a comment

sonarqubecloud bot commented Nov 24, 2022

Remove usage of Buildkite. #7583

Remove usage of Buildkite. #7583

Conversation

bmarty commented Nov 14, 2022 • edited Loading

Type of change

Content

Motivation and context

Screenshots / GIFs

Tests

Tested devices

Checklist

ElementBot commented Nov 14, 2022 • edited Loading

mnaturel Nov 15, 2022

Choose a reason for hiding this comment

bmarty Nov 16, 2022

Choose a reason for hiding this comment

bmarty Nov 16, 2022

Choose a reason for hiding this comment

mnaturel Nov 17, 2022

Choose a reason for hiding this comment

mnaturel Nov 15, 2022

Choose a reason for hiding this comment

bmarty Nov 16, 2022

Choose a reason for hiding this comment

bmarty Nov 16, 2022

Choose a reason for hiding this comment

mnaturel left a comment

Choose a reason for hiding this comment

mnaturel commented Nov 17, 2022

bmarty commented Nov 24, 2022

mnaturel left a comment

Choose a reason for hiding this comment

sonarqubecloud bot commented Nov 24, 2022

bmarty commented Nov 14, 2022 •

edited

Loading

ElementBot commented Nov 14, 2022 •

edited

Loading