Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix italic text is truncated when bubble mode and markdown is enabled (PSG-1006) #7601

Merged
merged 3 commits into from
Nov 18, 2022

Conversation

onurays
Copy link
Contributor

@onurays onurays commented Nov 17, 2022

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

When bubble mode and markdown are enabled, then italic texts are truncated at the end.
This is a known issue both for the library we use and the Android OS. The root cause is that it is not actually using an italic font instead it is just skewing the view of text.

Motivation and context

Fixes #5679.

Screenshots / GIFs

Before After
italic_before italic_after

Tests

  • Enable markdown formatting and bubble mode in settings
  • Send an italic message by using * message * (without spaces)

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

@onurays onurays requested review from a team and bmarty and removed request for a team November 17, 2022 12:59
@onurays onurays changed the title Fix italic text is truncated when bubble mode and markdown is enabled. Fix italic text is truncated when bubble mode and markdown is enabled (PSG-1006) Nov 17, 2022
Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@onurays onurays merged commit 664b066 into develop Nov 18, 2022
@onurays onurays deleted the feature/ons/fix_truncated_italic_text branch November 18, 2022 14:25
@shahimclt
Copy link

What does the term "bubble mode" mean in this context? I am having this issue and cant seem to fix it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Letter in italics cut off slightly in message bubble
3 participants