[RTE] Change layout based on plain text / rich text mode #7621

jmartinesp · 2022-11-21T08:52:31Z

Type of change

Feature
Bugfix
Technical
Other :

Content

Creates a ConstraintSet change when the rich text mode of the editor is enabled/disabled.
Disables the full screen button when either the rich text mode is disabled or it's in landscape orientation, since there is almost no vertical space available.

Motivation and context

Screenshots / GIFs

Before	After

Tests

Enabled the Rich Text Editor in Labs.
Enter a room, make sure your device is in portrait orientation (vertical).
Enter full screen mode using the 'maximise' button.
Tap on the "+" button, disable formatting. Check that the full screen mode was cancelled and there is no 'maximise' button anymore.
Enable formatting again, the maximise button should be back.
Enter full screen mode again.
Rotate the screen to landscape. Check that the full screen mode was disabled and there is no maximise button again.

Tested devices

Physical
Emulator
OS version(s): 13

Checklist

Changes has been tested on an Android device or Android emulator with API 21
UI change has been tested on both light and dark themes
Accessibility has been taken into account. See https://github.com/vector-im/element-android/blob/develop/CONTRIBUTING.md#accessibility
Pull request is based on the develop branch
Pull request includes a new file under ./changelog.d. See https://github.com/vector-im/element-android/blob/develop/CONTRIBUTING.md#changelog
Pull request includes screenshots or videos if containing UI changes
Pull request includes a sign off
You've made a self review of your PR
If you have modified the screen flow, or added new screens to the application, you have updated the test UiAllScreensSanityTest.allScreensTest()

bmarty · 2022-11-23T15:45:13Z

vector/src/main/java/im/vector/app/features/home/room/detail/composer/RichTextComposerLayout.kt

@@ -191,8 +197,7 @@ class RichTextComposerLayout @JvmOverloads constructor(
        }

        views.composerFullScreenButton.apply {
-            // There's no point in having full screen in landscape since there's almost no vertical space
-            isInvisible = resources.configuration.orientation == Configuration.ORIENTATION_LANDSCAPE


What about tablets here? Maybe add a boolean in the resource to take care of that?

bmarty · 2022-11-23T15:46:33Z

vector/src/main/java/im/vector/app/features/home/room/detail/composer/RichTextComposerLayout.kt

@@ -254,6 +259,33 @@ class RichTextComposerLayout @JvmOverloads constructor(
        views.richTextComposerEditText.isVisible = isTextFormattingEnabled
        views.richTextMenu.isVisible = isTextFormattingEnabled
        views.plainTextComposerEditText.isVisible = !isTextFormattingEnabled
+
+        // The layouts for formatted text mode and plain text mode are different, so we need to update the constraints
+        val dp = { px: Int -> (px * resources.displayMetrics.density).toInt() }
