ignore push for a thread if it's currently visible to user #7641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmarty
approved these changes
Nov 28, 2022
| @@ -142,11 +143,6 @@ class VectorPushHandler @Inject constructor( | |||
| pushData.roomId ?: return | |||
| pushData.eventId ?: return | |||
|
|
|||
| // If the room is currently displayed, we will not show a notification, so no need to get the Event faster | |||
| if (notificationDrawerManager.shouldIgnoreMessageEventInRoom(pushData.roomId)) { | |||
There was a problem hiding this comment.
I guess we do not have the threadId in the pushData, true?
| * Should be called when the application is currently opened and showing timeline for the given threadId. | ||
| * Used to ignore events related to that thread (no need to display notification) and clean any existing notification on this room. | ||
| */ | ||
| fun setCurrentThread(threadId: String?) { |
There was a problem hiding this comment.
Maybe merge with the method setCurrentRoom, just adding the parameter threadId: String? to it?
There was a problem hiding this comment.
user can switch between different threads in the same rooms, so i think it's better to separate changing room and changing thread
|
SonarCloud Quality Gate failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Content
we don't show push notification for a room which is currently observed by the user, but we should also take in account which thread timeline user observes
Motivation and context
closes #7634