Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Session manager] Add action to signout all the other session (PSG-888) #7696

Merged
merged 4 commits into from
Dec 5, 2022

Conversation

mnaturel
Copy link
Contributor

@mnaturel mnaturel commented Dec 2, 2022

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Adding a new menu overflow in the current session card view. It contains an action to signout from all the other sessions if any.

Motivation and context

Closes #7693

Screenshots / GIFs

Tests

  • Enable the new Session manager in the labs settings
  • Go to "Settings -> Security & Privacy -> Show all sessions"
  • Check the "Signout of all other sessions" menu item is only visible when there are other sessions
  • Press the menu item
  • Check there is a confirmation dialog
  • Confirm
  • Check all the other sessions are deleted

Tested devices

  • Physical
  • Emulator
  • OS version(s): Android 11

Checklist

@mnaturel mnaturel marked this pull request as ready for review December 2, 2022 16:26
@mnaturel mnaturel requested review from a team and onurays and removed request for a team December 2, 2022 16:26
@ElementBot
Copy link

Warnings
⚠️ Please add a reviewer to your PR.

Generated by 🚫 dangerJS against efc436c

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 2, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

Copy link
Contributor

@onurays onurays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@mnaturel mnaturel merged commit b5f6dc0 into develop Dec 5, 2022
@mnaturel mnaturel deleted the feature/mna/signout-all-other-sessions branch December 5, 2022 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Session manager] Add action to signout all the other session
3 participants