Replace react-rxjs with observable-hooks #2381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
robintown
force-pushed
the
observable-hooks
branch
from
ac748cd
to
5f344b7
Compare
robintown
force-pushed
the
observable-hooks
branch
from
5f344b7
to
1207496
Compare
robintown
force-pushed
the
observable-hooks
branch
from
1207496
to
fc570c5
Compare
robintown
force-pushed
the
observable-hooks
branch
from
fc570c5
to
8861a35
Compare
react-rxjs is the library we've been using to connect our React components to view models and consume observables. However, after spending some time with react-rxjs, I feel that it's a very heavy-handed solution. It requires us to sprinkle <Subscribe /> and <RemoveSubscribe /> components all throughout the code, and makes React go through an extra render cycle whenever we mount a component that binds to a view model. What I really want is a lightweight React hook that just gets the current value out of a plain observable, without any extra setup. Luckily the observable-hooks library with its useObservableEagerState hook seems to do just that—and it's more actively maintained, too!
robintown
force-pushed
the
observable-hooks
branch
from
8861a35
to
af0bd79
Compare
toger5
approved these changes
Jul 17, 2024
There was a problem hiding this comment.
This is somewhat hard to review because the changes are small and the diff editor moves things all over the place.
The things I have manged to find the counter parts look like straight forward refactoring.
In general this makes things easier.
Cool you found this solution! Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
react-rxjs is the library we've been using to connect our React components to view models and consume observables. However, after spending some time with react-rxjs, I feel that it's a very heavy-handed solution. It requires us to sprinkle
<Subscribe />and<RemoveSubscribe />components all throughout the code, and makes React go through an extra render cycle whenever we mount a component that binds to a view model. What I really want is a lightweight React hook that just gets the current value out of a plain observable, without any extra setup. Luckily the observable-hooks library with itsuseObservableEagerStatehook seems to do just that—and it's more actively maintained, too!Based on #2380