Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config to send session membership state events #2460

Merged
merged 3 commits into from
Jul 5, 2024

Conversation

AndrewFerr
Copy link
Member

If not set, legacy call membership state events are sent instead. Even if set, legacy events are sent in rooms with active legacy calls.

If not set, legacy call membership state events are sent instead.
Even if set, legacy events are sent in rooms with active legacy calls.
Copy link
Contributor

@toger5 toger5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added an optional proposal. I think stating that this setting "has no effect" in certain conditions communicates better that this is a "preferred" like setting than the "but" sentence.

src/config/ConfigOptions.ts Outdated Show resolved Hide resolved
Co-authored-by: Timo <16718859+toger5@users.noreply.github.com>
@AndrewFerr AndrewFerr merged commit 34c7d02 into livekit Jul 5, 2024
3 checks passed
@AndrewFerr AndrewFerr deleted the af/config-nonlegacy branch July 5, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants