Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include the hostname of where EC is running in rageshakes #2616

Merged
merged 1 commit into from
Sep 9, 2024
Merged

Include the hostname of where EC is running in rageshakes #2616

merged 1 commit into from
Sep 9, 2024

Conversation

hughns
Copy link
Member

@hughns hughns commented Sep 9, 2024

Or, are we excluding this for privacy reasons? I would be surprised if so given that hostnames are included in other places along with the full Matrix ID.

@hughns hughns requested a review from a team as a code owner September 9, 2024 09:25
toger5
toger5 approved these changes Sep 9, 2024
View reviewed changes
Copy link
Contributor

@toger5 toger5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it was mostly not included since it is already part of the matrix.id. But having it here explicitly makes things easier.

@hughns hughns merged commit c30c8ac into livekit Sep 9, 2024
6 checks passed
@hughns hughns deleted the hughns/rageshake-hostname branch September 9, 2024 10:14
hughns added a commit that referenced this pull request Sep 9, 2024
@hughns
Include the hostname of where EC is running in rageshakes (#2616)
102399a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toger5 toger5 toger5 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hughns @toger5