Intercept matrix_sdk logging via console and include in rageshake #2623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewFerr
requested changes
Sep 20, 2024
Comment on lines
+481
to
+489
| ( | ||
| ["trace", "debug", "info", "warn", "error"] as ( | ||
| | "trace" | ||
| | "debug" | ||
| | "info" | ||
| | "warn" | ||
| | "error" | ||
| )[] | ||
| ).forEach((level) => { |
There was a problem hiding this comment.
This is slightly less nasty:
Suggested change
| ( | |
| ["trace", "debug", "info", "warn", "error"] as ( | |
| | "trace" | |
| | "debug" | |
| | "info" | |
| | "warn" | |
| | "error" | |
| )[] | |
| ).forEach((level) => { | |
| [ | |
| "trace" as const, | |
| "debug" as const, | |
| "info" as const, | |
| "warn" as const, | |
| "error" as const, | |
| ].forEach((level) => { |
And thank https://typescript-eslint.io/rules/prefer-as-const/ for teaching me about "as const" 😃
Comment on lines
+490
to
+492
| if (!window.console[level]) return; | ||
| const prefix = `${level.toUpperCase()} matrix_sdk`; | ||
| const originalMethod = window.console[level]; |
There was a problem hiding this comment.
Nitpick, rearrange some lines to avoid a redundant lookup on window.console
Suggested change
| if (!window.console[level]) return; | |
| const prefix = `${level.toUpperCase()} matrix_sdk`; | |
| const originalMethod = window.console[level]; | |
| const originalMethod = window.console[level]; | |
| if (!originalMethod) return; | |
| const prefix = `${level.toUpperCase()} matrix_sdk`; |
| window.console[level] = (...args): void => { | ||
| originalMethod(...args); | ||
| if (typeof args[0] === "string" && args[0].startsWith(prefix)) { | ||
| global.mx_rage_logger.log(LogLevel[level], "matrix_sdk", ...args); |
There was a problem hiding this comment.
Is passing the entire args array intentional, or should args[0] (i.e. the argument with the prefix) be excluded?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.