-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test useTheme hook #2625
Open
toger5
wants to merge
1
commit into
livekit
Choose a base branch
from
toger5/useTheme_test
base: livekit
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Test useTheme hook #2625
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
@@ -0,0 +1,122 @@ | ||||||
/* | ||||||
Copyright 2024 New Vector Ltd. | ||||||
|
||||||
SPDX-License-Identifier: AGPL-3.0-only | ||||||
Please see LICENSE in the repository root for full details. | ||||||
*/ | ||||||
|
||||||
import { renderHook } from "@testing-library/react-hooks"; | ||||||
import { | ||||||
afterEach, | ||||||
beforeEach, | ||||||
describe, | ||||||
expect, | ||||||
Mock, | ||||||
test, | ||||||
vi, | ||||||
} from "vitest"; | ||||||
|
||||||
import { useTheme } from "./useTheme"; | ||||||
import { useUrlParams } from "./UrlParams"; | ||||||
|
||||||
// Mock the useUrlParams hook | ||||||
vi.mock("./UrlParams", () => ({ | ||||||
useUrlParams: vi.fn(), | ||||||
})); | ||||||
|
||||||
describe("useTheme", () => { | ||||||
let originalClassList: DOMTokenList; | ||||||
beforeEach(() => { | ||||||
// Save the original classList so we can restore it later | ||||||
originalClassList = document.body.classList; | ||||||
|
||||||
vi.spyOn(document.body.classList, "add").mockImplementation(vi.fn()); | ||||||
vi.spyOn(document.body.classList, "remove").mockImplementation(vi.fn()); | ||||||
vi.spyOn(document.body.classList, "item").mockImplementation(() => null); | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
}); | ||||||
|
||||||
afterEach(() => { | ||||||
vi.clearAllMocks(); | ||||||
}); | ||||||
|
||||||
test("should apply dark theme by default when no theme is specified", () => { | ||||||
// Mock useUrlParams to return no theme | ||||||
(useUrlParams as Mock).mockReturnValue({ theme: null }); | ||||||
|
||||||
renderHook(() => useTheme()); | ||||||
|
||||||
expect(originalClassList.remove).toHaveBeenCalledWith( | ||||||
"cpd-theme-light", | ||||||
"cpd-theme-dark", | ||||||
"cpd-theme-light-hc", | ||||||
"cpd-theme-dark-hc", | ||||||
); | ||||||
expect(originalClassList.add).toHaveBeenCalledWith("cpd-theme-dark"); | ||||||
}); | ||||||
|
||||||
test("should apply light theme when theme is set to light", () => { | ||||||
// Mock useUrlParams to return light theme | ||||||
(useUrlParams as Mock).mockReturnValue({ theme: "light" }); | ||||||
|
||||||
renderHook(() => useTheme()); | ||||||
|
||||||
expect(originalClassList.remove).toHaveBeenCalledWith( | ||||||
"cpd-theme-light", | ||||||
"cpd-theme-dark", | ||||||
"cpd-theme-light-hc", | ||||||
"cpd-theme-dark-hc", | ||||||
); | ||||||
expect(originalClassList.add).toHaveBeenCalledWith("cpd-theme-light"); | ||||||
}); | ||||||
|
||||||
test("should apply dark-high-contrast theme when theme is set to dark-high-contrast", () => { | ||||||
// Mock useUrlParams to return dark-high-contrast theme | ||||||
(useUrlParams as Mock).mockReturnValue({ | ||||||
theme: "dark-high-contrast", | ||||||
}); | ||||||
|
||||||
renderHook(() => useTheme()); | ||||||
|
||||||
expect(originalClassList.remove).toHaveBeenCalledWith( | ||||||
"cpd-theme-light", | ||||||
"cpd-theme-dark", | ||||||
"cpd-theme-light-hc", | ||||||
"cpd-theme-dark-hc", | ||||||
); | ||||||
expect(originalClassList.add).toHaveBeenCalledWith("cpd-theme-dark-hc"); | ||||||
}); | ||||||
|
||||||
test("should apply light-high-contrast theme when theme is set to light-high-contrast", () => { | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Non-blocking, but this and the above tests are very similar, so |
||||||
// Mock useUrlParams to return light-high-contrast theme | ||||||
(useUrlParams as Mock).mockReturnValue({ | ||||||
theme: "light-high-contrast", | ||||||
}); | ||||||
|
||||||
renderHook(() => useTheme()); | ||||||
|
||||||
expect(originalClassList.remove).toHaveBeenCalledWith( | ||||||
"cpd-theme-light", | ||||||
"cpd-theme-dark", | ||||||
"cpd-theme-light-hc", | ||||||
"cpd-theme-dark-hc", | ||||||
); | ||||||
expect(originalClassList.add).toHaveBeenCalledWith("cpd-theme-light-hc"); | ||||||
}); | ||||||
|
||||||
test("should not reapply the same theme if it hasn't changed", () => { | ||||||
// Mock useUrlParams to return dark theme initially | ||||||
(useUrlParams as Mock).mockReturnValue({ theme: "dark" }); | ||||||
// Simulate a previous theme | ||||||
originalClassList.item = vi.fn().mockReturnValue("cpd-theme-dark"); | ||||||
|
||||||
renderHook(() => useTheme()); | ||||||
|
||||||
expect(document.body.classList.add).not.toHaveBeenCalledWith( | ||||||
"cpd-theme-dark", | ||||||
); | ||||||
|
||||||
// Ensure the 'no-theme' class is removed | ||||||
expect(document.body.classList.remove).toHaveBeenCalledWith("no-theme"); | ||||||
expect(originalClassList.add).not.toHaveBeenCalled(); | ||||||
}); | ||||||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally
.mockImplementation(() => {})
or.mockImplementation(vi.fn())
is a no-op, so these can likely be