Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't trigger keyboard shortcuts if modifiers are held #2831

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

robintown
Copy link
Member

None of these keyboard shortcuts expect modifier keys, so they should in fact expect the absence of modifiers.

Closes #2824

None of these keyboard shortcuts expect modifier keys, so they should in fact expect the absence of modifiers.
@robintown robintown requested a review from a team as a code owner November 22, 2024 18:18
Copy link
Member

@hughns hughns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@robintown robintown merged commit 1bbbd51 into element-hq:livekit Nov 22, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Keyboard shortcuts for sending emoji reactions breaks ability to change tab.
2 participants