Improve seshat deleteContents #1916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robintown
approved these changes
Oct 11, 2024
|
Thanks @robintown , we were swallowing the errors at the call site before, so wasn't sure if there was a reason for that. But yea, maybe better to log them, mind taking another look? |
…angleyd/fix_seshat_delete_contents
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides workaround(fixes search "Reset" button) for #1822
The problem I saw was that a file with a prefix like
.atomicwrite.<ID>existed in theEventStoredirectory that the application did not have permissions to delete(got a "Error: EPERM: operation not permitted" error for the unlink). Maybe a seshat write was in progress during a previous run of the app when it was aborted, leaving it orphaned.As there was no try/catch within the loop in deleteContents it would failed to delete any of the files after
.atomicwrite.<ID>(most of them likely). This meant subsequent initialisations of seshat didn't work and it could never be reset in the UI.