Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade to electron 20.3.4 to fix crash on call hangup #459

Merged
merged 3 commits into from
Nov 22, 2022

Conversation

dbkr
Copy link
Member

@dbkr dbkr commented Nov 21, 2022

Fixes element-hq/element-web#23783

Choose either this or #460

Checklist

  • Ensure your code works with manual testing
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

Here's what your changelog entry will look like:

🐛 Bug Fixes

@dbkr dbkr added the T-Defect label Nov 21, 2022
@dbkr dbkr requested a review from a team as a code owner November 21, 2022 19:07
@dbkr dbkr requested review from richvdh and robintown November 21, 2022 19:07
@t3chguy
Copy link
Member

t3chguy commented Nov 21, 2022

Does 21 not fix this? Is there any upstream issue?

Copy link
Member

@robintown robintown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd also like to know if we could upgrade

@dbkr
Copy link
Member Author

dbkr commented Nov 21, 2022

I didn't test as I assumed a major update of electron would be out of the question for a last minute release pre-release patch, but yes, just tested 21.3.0 and that's fine too. Doesn't look like any of the breaking changes would be relevant. Have PRed that in #460 so you can choose your own adventure.

@dbkr dbkr mentioned this pull request Nov 21, 2022
3 tasks
Copy link
Member

@robintown robintown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess if we could merge this to the release branch, and #458 to the develop branch, that'd be best

@t3chguy t3chguy changed the base branch from develop to staging November 21, 2022 21:54
@t3chguy
Copy link
Member

t3chguy commented Nov 21, 2022

Luckily this repo is quiet enough that it didn't need rebasing :D

@t3chguy t3chguy merged commit b35dbfe into staging Nov 22, 2022
@t3chguy t3chguy deleted the dbkr/electron_20_3_4 branch November 22, 2022 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Element white-screen-of-deaths when I hang up a Matrix-native 1:1 call
4 participants