-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Downgrade to electron 20.3.4 to fix crash on call hangup #459
Conversation
Does 21 not fix this? Is there any upstream issue? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd also like to know if we could upgrade
I didn't test as I assumed a major update of electron would be out of the question for a last minute release pre-release patch, but yes, just tested 21.3.0 and that's fine too. Doesn't look like any of the breaking changes would be relevant. Have PRed that in #460 so you can choose your own adventure. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess if we could merge this to the release branch, and #458 to the develop branch, that'd be best
Luckily this repo is quiet enough that it didn't need rebasing :D |
Fixes element-hq/element-web#23783
Choose either this or #460
Checklist
Here's what your changelog entry will look like:
🐛 Bug Fixes