Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reply of reply renders badly #2086

Closed
manuroe opened this issue Oct 25, 2018 · 2 comments
Closed

Reply of reply renders badly #2086

manuroe opened this issue Oct 25, 2018 · 2 comments
Labels
P2 T-Defect Something isn't working: bugs, crashes, hangs and other reported problems
Milestone

Comments

@manuroe
Copy link
Member

manuroe commented Oct 25, 2018

https://matrix.to/#/!QtykxKocfZaZOUrTwp:matrix.org/$1540454259581859dfukb:matrix.org is a case where a reply is badly displayed:

Instead of:
screen shot 2018-10-25 at 12 43 40

@manuroe manuroe added T-Defect Something isn't working: bugs, crashes, hangs and other reported problems P2 labels Oct 25, 2018
@manuroe manuroe added this to the Sprint 14 milestone Oct 25, 2018
@manuroe
Copy link
Member Author

manuroe commented Oct 31, 2018

Well, Riot-web renders it badly too. :/ yeah ... appears 2 times on the riot-web screenshot.

The issue comes from a malformed reply (there are 2 <mx-reply> blocks in event.content:

{
  "origin_server_ts": 1540454259606,
  "sender": "@matthew:matrix.org",
  "event_id": "$1540454259581859dfukb:matrix.org",
  "content": {
    "body": "> <@aaron:raim.ist> :/ yeah\n> he responded to you later to say \"ignore me\", you'll probably get that in a few minutes\n\nI have no way to guess when federation is delayed talking to a given server, so I’m going to moderate conversation as I see it. that means ensuring that users who are currently discussing matrix-the-protocol aren’t told they should go elsewhere. it’s nothing personal whatsoever, although i’m amused to see it spun that way.",
    "m.relates_to": {
      "m.in_reply_to": {
        "event_id": "$1540434413178IqzmN:raim.ist"
      }
    },
    "msgtype": "m.text",
    "formatted_body": "<mx-reply><blockquote><a href=\"https://matrix.to/#/!QtykxKocfZaZOUrTwp:matrix.org/$1540434413178IqzmN:raim.ist\">In reply to</a> <a href=\"https://matrix.to/#/@aaron:raim.ist\">@aaron:raim.ist</a><br><mx-reply><blockquote><a href=\"https://matrix.to/#/!QtykxKocfZaZOUrTwp:matrix.org/$1540434335372IRLPP:kamax.io\">In reply to</a> <a href=\"https://matrix.to/#/@max:kamax.io\">@max:kamax.io</a><br><p>(Note that matrix.org federation is broken so I see things hours later from it.) <strong>Please stop pinging me with negative words everytime I say something  you do not like.</strong> It feel like harrassement and it makes people unable to just reply to people who need help. I asked you several times already.</p>\n<p>The question was about the repos of construct and which one is the correct one. That is the official room for Construct which is on-topic for the question. But since you have time to ping me, I'm sure you had time to work on <a href=\"https://github.com/matrix-org/matrix-doc/issues/1194\">#1194</a> which keeps on breaking users servers like <a href=\"https://github.com/matrix-org/synapse/issues/4028\">this poor fellow</a> which is still stuck 14 days later?</p>\n</blockquote></mx-reply>:/ yeah<br />he responded to you later to say &quot;ignore me&quot;, you'll probably get that in a few minutes</blockquote></mx-reply>I have no way to guess when federation is delayed talking to a given server, so I’m going to moderate conversation as I see it. that means ensuring that users who are currently discussing matrix-the-protocol aren’t told they should go elsewhere. it’s nothing personal whatsoever, although i’m amused to see it spun that way.",
    "format": "org.matrix.custom.html"
  },
  "room_id": "!QtykxKocfZaZOUrTwp:matrix.org",
  "type": "m.room.message",
  "unsigned": {
    "age": 524952982
  },
  "user_id": "@matthew:matrix.org",
  "age": 524952982
}

@manuroe
Copy link
Member Author

manuroe commented Oct 31, 2018

This event was created by Riot-iOS which failed to create a valid reply from https://matrix.to/#/!QtykxKocfZaZOUrTwp:matrix.org/$1540434413178IqzmN:raim.ist?via=matrix.org&via=half-shot.uk&via=disroot.org&via=t2bot.io.

Because the reply in it contains an unexpected newline (\n).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 T-Defect Something isn't working: bugs, crashes, hangs and other reported problems
Projects
None yet
Development

No branches or pull requests

1 participant