-
Notifications
You must be signed in to change notification settings - Fork 486
-
Notifications
You must be signed in to change notification settings - Fork 486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incredible slow sync due to interrupted storing #376
Comments
We suggest keeping the existing storage until the end of the saving process. The saving process may still be interrupted when the existing storage is replaced, but this operation is faster. The probability to detect a corrupted storage should be reduced. We still need to notify the user when the local storage is reset to fix file corruption. |
Brief notes from talking to @manuroe about this on Monday: I think we can fake atomic saves with rollback without having to resync the world, and without switching to using realm.io or similar:
If there were local echos being persisted in the partial file, then they will obviously get lost when resyncing from /sync results, but c'est la vie. |
… needs to by backuped too. element-hq/element-ios#376
…in case of interruption. element-hq/element-ios#376
… deleteRoom] follow the same async process as other methods element-hq/element-ios#376
FTR, MXFileStore files has been reorganised like this: https://github.com/matrix-org/matrix-ios-sdk/blob/13cd0c3f6f16cfe6dc8c87055de98ed74d7d0616/MatrixSDK/Data/Store/MXFileStore/MXFileStore.h#L27 |
Matthew complains on incredible slow sync, this appends when the previous saving was interrupted.
Notify the user should be useful here
The text was updated successfully, but these errors were encountered: