Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Privacy: Add/Change/Remove IS from settings #2735

Merged
merged 24 commits into from
Sep 27, 2019
Merged

Privacy: Add/Change/Remove IS from settings #2735

merged 24 commits into from
Sep 27, 2019

Conversation

manuroe
Copy link
Member

@manuroe manuroe commented Sep 26, 2019

Fixes #2604.
Fixes #2649.
Fixes #2734.
Fixes #2736.
Requires matrix-org/matrix-ios-sdk#724.

There is a TODO that will be managed after #2713.

Simulator Screen Shot - iPhone 8 - 2019-09-26 at 16 43 49
Screen Recording 2019-09-26 at 16 41 40

@manuroe manuroe requested a review from giomfo September 26, 2019 14:47
@manuroe manuroe changed the title [WIP] Privacy: Add/Change/Remove IS from settings Privacy: Add/Change/Remove IS from settings Sep 26, 2019
Copy link
Member

@giomfo giomfo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM (only one comment)

@manuroe manuroe merged commit dc095ed into privacy Sep 27, 2019
@manuroe manuroe deleted the riot_2604 branch September 27, 2019 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants