Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Message bubbles: Add settings and build flag #5342

Merged
merged 8 commits into from
Jan 13, 2022

Conversation

SBiOSoftWhare
Copy link
Contributor

@SBiOSoftWhare SBiOSoftWhare requested a review from amshakal January 4, 2022 09:42
@github-actions
Copy link

github-actions bot commented Jan 4, 2022

📱 Scan the QR code below to install the build for this PR.
🔒 This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

QR code

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/iX1iM1

Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I liked RoomTimelineStyle better than RoomTimelineStyleIdentifier. If you feel it was too simple maybe RoomTimelineDisplayStyle works better.
Otherwise, looks good to me 👍

@SBiOSoftWhare
Copy link
Contributor Author

I liked RoomTimelineStyle better than RoomTimelineStyleIdentifier. If you feel it was too simple maybe RoomTimelineDisplayStyle works better.
Otherwise, looks good to me 👍

Thanks. Yes in fact it's because you choose in the settings an style identifier and then with this identifier you can instantiate a style instance.

@objcMembers
class RoomTimelineConfiguration: NSObject {
...
    private class func style(for identifier: RoomTimelineStyleIdentifier) -> RoomTimelineStyle {
        
        let roomTimelineStyle: RoomTimelineStyle
        
        switch identifier {
        case .plain:
            roomTimelineStyle = PlainRoomTimelineStyle()
        case .bubble:
            roomTimelineStyle = BubbleRoomTimelineStyle()
        }
        
        return roomTimelineStyle
    }

@stefanceriu
Copy link
Member

Ah l, got it, all good then 😁

@SBiOSoftWhare SBiOSoftWhare merged commit 565b1cc into develop Jan 13, 2022
@SBiOSoftWhare SBiOSoftWhare deleted the steve/5321_bubbles_lauching branch January 13, 2022 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants