Deprecate MXLegacyCrypto #7508
Merged
Deprecate MXLegacyCrypto #7508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anderas
force-pushed
the
andy/deprecate_crypto
branch
from
5211528
to
11d2dee
Compare
Anderas
force-pushed
the
andy/deprecate_crypto
branch
from
11d2dee
to
59dffb5
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Anderas
requested review from
a team and
aringenbach
and removed request for
a team
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #7508 +/- ##
===========================================
- Coverage 12.36% 12.34% -0.02%
===========================================
Files 1645 1643 -2
Lines 163432 162971 -461
Branches 67085 65984 -1101
===========================================
- Hits 20201 20116 -85
+ Misses 142572 142195 -377
- Partials 659 660 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 4 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related SDK change matrix-org/matrix-ios-sdk#1772
Deprecate the use of
MXLegacyCrypto, which is no longer initialized on the SDK side. This means mostly removing conditional statements accessing now-unavailable API on legacy crypto module