Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open MAS Web page when logging out from other sessions on OIDC authenticated homeservers #7657

Merged
merged 2 commits into from
Aug 28, 2023

Conversation

Velin92
Copy link
Member

@Velin92 Velin92 commented Aug 25, 2023

fixes #7646

Requires this to be merged to develop first:
matrix-org/matrix-ios-sdk#1813

@codecov
Copy link

codecov bot commented Aug 25, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (c2874d6) 12.21% compared to head (e0659dd) 12.21%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #7657   +/-   ##
========================================
  Coverage    12.21%   12.21%           
========================================
  Files         1648     1648           
  Lines       163652   163675   +23     
  Branches     67171    67183   +12     
========================================
+ Hits         19994    19997    +3     
- Misses      143012   143032   +20     
  Partials       646      646           
Flag Coverage Δ
uitests 55.04% <ø> (ø)
unittests 6.06% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...curity/ManageSession/ManageSessionViewController.m 0.00% <0.00%> (ø)
...ions/Coordinator/UserSessionsFlowCoordinator.swift 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Velin92 Velin92 requested a review from pixlwave August 25, 2023 17:36
@sonarcloud
Copy link

sonarcloud bot commented Aug 25, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (11.0.14) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@Velin92 Velin92 merged commit f7a3a80 into develop Aug 28, 2023
11 checks passed
@Velin92 Velin92 deleted the mauroromito/mas_device_logout branch August 28, 2023 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EI: Link to MAS for sign-out in MSC3824 OIDC-aware mode
2 participants