Skip to content

Commit

Permalink
Don't hardcode /bin/bash in scripts (#23740)
Browse files Browse the repository at this point in the history
Some operating systems, such as NixOS, don't place binaries in /bin. The appropriate cross-platform method is to use /usr/bin/env.
  • Loading branch information
robintown committed Nov 9, 2022
1 parent bc6d1c3 commit 46c005a
Show file tree
Hide file tree
Showing 10 changed files with 10 additions and 10 deletions.
2 changes: 1 addition & 1 deletion release.sh
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#!/bin/bash
#!/usr/bin/env bash
#
# Script to perform a release of element-web.

Expand Down
2 changes: 1 addition & 1 deletion scripts/ci_package.sh
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#!/bin/bash
#!/usr/bin/env bash

# Runs package.sh, passing DIST_VERSION determined by git

Expand Down
2 changes: 1 addition & 1 deletion scripts/docker-link-repos.sh
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#!/bin/bash
#!/usr/bin/env bash

set -ex

Expand Down
2 changes: 1 addition & 1 deletion scripts/docker-package.sh
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#!/bin/bash
#!/usr/bin/env bash

set -ex

Expand Down
2 changes: 1 addition & 1 deletion scripts/fetch-develop.deps.sh
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#!/bin/bash
#!/usr/bin/env bash

# Fetches the js-sdk and matrix-react-sdk dependencies for development
# or testing purposes
Expand Down
2 changes: 1 addition & 1 deletion scripts/get-version-from-git.sh
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#!/bin/bash
#!/usr/bin/env bash

# Echoes a version based on the git hashes of the element-web, react-sdk & js-sdk checkouts, for the case where
# these dependencies are git checkouts.
Expand Down
2 changes: 1 addition & 1 deletion scripts/layered.sh
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#!/bin/bash
#!/usr/bin/env bash

set -ex

Expand Down
2 changes: 1 addition & 1 deletion scripts/make-icons.sh
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#!/bin/bash
#!/usr/bin/env bash
#
# Converts an svg logo into the various image resources required by
# the various platforms deployments.
Expand Down
2 changes: 1 addition & 1 deletion scripts/normalize-version.sh
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#!/bin/bash
#!/usr/bin/env bash

set -e

Expand Down
2 changes: 1 addition & 1 deletion scripts/package.sh
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#!/bin/bash
#!/usr/bin/env bash

set -e

Expand Down

0 comments on commit 46c005a

Please sign in to comment.