Skip to content

Commit

Permalink
Merge pull request #7518 from vector-im/dbkr/better_fix_for_windows_c…
Browse files Browse the repository at this point in the history
…rashes

Don't set tags on notifications
  • Loading branch information
dbkr committed Oct 18, 2018
2 parents 47493fa + 2854c09 commit c1dfbd6
Showing 1 changed file with 0 additions and 6 deletions.
6 changes: 0 additions & 6 deletions src/vector/platform/ElectronPlatform.js
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,6 @@ export default class ElectronPlatform extends VectorBasePlatform {
{
body: msg,
icon: avatarUrl,
tag: 'vector',
silent: true, // we play our own sounds
},
);
Expand All @@ -169,11 +168,6 @@ export default class ElectronPlatform extends VectorBasePlatform {
}

clearNotification(notif: Notification) {
// This crashes on windows under certain circumstances: can't find any
// workaround other than not closing notifs.
// https://github.com/electron/electron/issues/15251
// https://github.com/vector-im/riot-web/issues/7512
if (window.process.platform === 'win32') return;
notif.close();
}

Expand Down

0 comments on commit c1dfbd6

Please sign in to comment.