Skip to content

Commit

Permalink
Move min-height to RoomList; remove bottommost prop
Browse files Browse the repository at this point in the history
  • Loading branch information
kegsay committed Dec 18, 2015
1 parent dc1e201 commit dcea0dd
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 8 deletions.
4 changes: 1 addition & 3 deletions src/components/structures/RoomSubList.js
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,6 @@ var RoomSubList = React.createClass({
tagName: React.PropTypes.string,
editable: React.PropTypes.bool,
order: React.PropTypes.string.isRequired,
bottommost: React.PropTypes.bool,
selectedRoom: React.PropTypes.string.isRequired,
activityMap: React.PropTypes.object.isRequired,
startAsHidden: React.PropTypes.bool,
Expand Down Expand Up @@ -290,8 +289,7 @@ var RoomSubList = React.createClass({

if (this.state.sortedList.length > 0 || this.props.editable) {
var subList;
var classes = "mx_RoomSubList" +
(this.props.bottommost ? " mx_RoomSubList_bottommost" : "");
var classes = "mx_RoomSubList";

if (!this.state.hidden) {
subList = <div className={ classes }>
Expand Down
1 change: 1 addition & 0 deletions src/skins/vector/css/organisms/RoomList.css
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ limitations under the License.
.mx_RoomList {
padding-top: 24px;
padding-bottom: 12px;
min-height: 400px;
}

.mx_RoomList_expandButton {
Expand Down
5 changes: 0 additions & 5 deletions src/skins/vector/css/organisms/RoomSubList.css
Original file line number Diff line number Diff line change
Expand Up @@ -20,11 +20,6 @@ limitations under the License.
width: 100%;
}

.mx_RoomSubList_bottommost {
/* XXX: this should really be 100% of the RoomList height, but can't seem to get at it */
min-height: 400px;
}

.mx_RoomSubList_label {
text-transform: uppercase;
color: #3d3b39;
Expand Down

0 comments on commit dcea0dd

Please sign in to comment.