Merge pull request #6763 from vector-im/dbkr/fix_electron_menus

Fix right click menu in electron
element-hq · May 18, 2018 · e5fd579 · e5fd579
2 parents 1e8bb5e + 6722eed
commit e5fd579
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/electron_app/src/webcontents-handler.js b/electron_app/src/webcontents-handler.js
@@ -61,7 +61,8 @@ function onLinkContextMenu(ev, params) {
             clipboard.writeText(url);
         },
     }));
-    popupMenu.popup();
+    // popup() requires an options object even for no options
+    popupMenu.popup({});
     ev.preventDefault();
 }
 
@@ -88,7 +89,8 @@ function onSelectedContextMenu(ev, params) {
     const items = _CutCopyPasteSelectContextMenus(params);
     const popupMenu = Menu.buildFromTemplate(items);
 
-    popupMenu.popup();
+    // popup() requires an options object even for no options
+    popupMenu.popup({});
     ev.preventDefault();
 }
 
@@ -101,7 +103,8 @@ function onEditableContextMenu(ev, params) {
 
     const popupMenu = Menu.buildFromTemplate(items);
 
-    popupMenu.popup();
+    // popup() requires an options object even for no options
+    popupMenu.popup({});
     ev.preventDefault();
 }