-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Store identity server in Account Data and support choosing identity server integration in User Settings #10094
Comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
After validating today, latest comps are in Zeplin: https://zpl.io/brMdWo3 |
One thing that's not clear on this is how this should work with all the other places that specify ISes, ie. if the one you had at login time (be that from your client's default, .well-known or entered), is that then discarded in favour of using the one in your account settings? I'm going to assume so for now. |
Another complexity is that (similar to the Disconnect button in #10425), we need to ensure all your 3PIDs are unbound (both on the IS itself and also the HS record of where your 3PIDs are bound) before actually changing the IS. |
Just changes the current ID server being used To come in subsequent PRs: * Store this in account data * Check for terms or support the proper UI for accepting terms when setting * Support disconnecting Part 1 of element-hq/element-web#10094 Requires matrix-org/matrix-js-sdk#1013
We should no longer have an IS 'supplied at login time' - rather there is a 'default' that is 'the Identity Server the client would prompt to use if asked to do something identity servery and the user has not made an active choice to use either a different identity server or no identity servrer at all'. This 'default' could be specified in the config.json or in .well-known (I can't think of anywhere else sensible to provide this at the moment), or it could not be specified at all. There is an unanswered question about what we do if an admin wants to provide a matrix stack with a locked-down IS choice. I think answering this question is hard, so despite the risk of our painting ourselves into a corner with the proposed, I'd like to keep a lid on this for now and tackle it if/when we have a concrete usecase to consider. |
The nice inline terms dialog has been spun out to #10539 as it's not as critial-path as the rest of this. |
Second part of this is done. I think @turt2live is working on the first part. |
Kamino cloned this issue to vector-im/riot-ios |
I've reclaimed this for the storing in account data part. matrix-org/matrix-react-sdk#3300 has been added to "in test" for Dave's portion of the work. MSC I need to care about: matrix-org/matrix-spec-proposals#2230 |
Additional requirements:
The text was updated successfully, but these errors were encountered: