Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reaction tooltip not popping up when reaction button clicked on touchscreen #10225

Closed
Cnly opened this issue Jul 1, 2019 · 1 comment · Fixed by matrix-org/matrix-react-sdk#3169
Closed

Reaction tooltip not popping up when reaction button clicked on touchscreen #10225

Cnly opened this issue Jul 1, 2019 · 1 comment · Fixed by matrix-org/matrix-react-sdk#3169
Assignees
@jryans
Labels
A-Aggregations A-Reactions T-Defect

Comments

@Cnly
Copy link

Cnly commented Jul 1, 2019

Description

The reaction tooltip is not popping up when the reaction button is clicked on a touchscreen. It has no problem when I'm using a mouse.

This can also be reproduced with the mobile simulator in Chrome DevTools.

Steps to reproduce

  • Click the reaction button on a touchscreen.

Version information

  • Platform: Web
  • Browser: Chrome 76.0.3809.38
  • OS: Chrome OS
  • URL: riot.im/develop
@Cnly Cnly added the T-Defect label Jul 1, 2019
@jryans
Copy link
Collaborator

jryans commented Jul 1, 2019

It turns out this is also fixed by some tweaks I am making to the tooltip.

@jryans jryans self-assigned this Jul 1, 2019
jryans added a commit to matrix-org/matrix-react-sdk that referenced this issue Jul 1, 2019
@jryans
Improve interactive tooltip hover behaviour
3acdf27 
This gives the interactive tooltip a more natural hover behaviour by removing
the full screen div behind it. This allows the target button to keep its hover
state, for example.

This also removes the click to close behavior, which was too easy to trigger
accidentally.

Fixes element-hq/element-web#10179
Fixes element-hq/element-web#10222
Fixes element-hq/element-web#10225
jryans added a commit to matrix-org/matrix-react-sdk that referenced this issue Jul 1, 2019
@jryans
Improve interactive tooltip hover behaviour
dd94bf7 
This gives the interactive tooltip a more natural hover behaviour by removing
the full screen div behind it. This allows the target button to keep its hover
state, for example.

This also removes the click to close behaviour, which was too easy to trigger
accidentally.

Fixes element-hq/element-web#10179
Fixes element-hq/element-web#10222
Fixes element-hq/element-web#10225
@jryans jryans mentioned this issue Jul 1, 2019
Merged
@lampholder lampholder added phase:4 and removed phase:3 labels Jul 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jryans jryans

Labels
A-Aggregations A-Reactions T-Defect
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve interactive tooltip hover behaviour matrix-org/matrix-react-sdk
3 participants
@jryans @lampholder @Cnly