Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update discovery and account 3PID sections when either changes #10519

Closed
jryans opened this issue Aug 7, 2019 · 0 comments · Fixed by matrix-org/matrix-react-sdk#3419
Closed

Update discovery and account 3PID sections when either changes #10519

jryans opened this issue Aug 7, 2019 · 0 comments · Fixed by matrix-org/matrix-react-sdk#3419
Assignees
@jryans
Labels
A-Identity-Server A-User-Settings Privacy

Comments

@jryans
Copy link
Collaborator

jryans commented Aug 7, 2019

The first cut of sharing / revoking 3PIDs from #10159 is slightly awkward, as the discovery and account sections each have a list of 3PIDs, but they don't currently update in response to changes from the other section.

This requires reworking some the settings state management.
This was referenced Aug 7, 2019
Closed
Merged
@jryans jryans added phase:1 and removed phase:2 labels Sep 6, 2019
@jryans jryans self-assigned this Sep 9, 2019
jryans added a commit to matrix-org/matrix-react-sdk that referenced this issue Sep 11, 2019
@jryans
Lift 3PID state management up to Settings tab
f04c347 
This pulls the 3PID state management in Settings up to a single location so that
the Account and Discovery sections now work from a single list that updates
immediately.

Fixes element-hq/element-web#10519
@jryans jryans mentioned this issue Sep 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jryans jryans

Labels
A-Identity-Server A-User-Settings Privacy
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Lift 3PID state management up to Settings tab matrix-org/matrix-react-sdk
1 participant
@jryans